Refactor update testdata script

[luke-hill]

🤔 What's changed?

⚡️ What's your motivation?

🏷️ What kind of change is this?

• 📖 Documentation (improvements without changing code)
• 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
• 🐛 Bug fix (non-breaking change which fixes a defect)
• ⚡ New feature (non-breaking change which adds new behaviour)
• 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[mpkorstanje]

Missing from this test case because GITHUB_REF is only relevant when a CI job is triggered on a tag.

We're missing a test case for when a build is triggered by a tag.

[mpkorstanje]

Missing from this test case because CI_COMMIT_TAG is only relevant when a CI job is triggered on a tag.

We're also missing a test case for when a build is triggered by a tag.

[mpkorstanje]

The * matches the branch name. I.e: GO_SCM_MY_MATERIAL_PR_BRANCH So this is a limitation of the script.

[mpkorstanje]

Nice find.

It looks like update_testdata.rb got over taken by the complexity of different CI systems. The script effectively checks which variables are used in the bash-like substitutions in CiEnviornments.json. But this assumes all variables are always used or present, which is not the case.

I'll add a few test cases.

[mpkorstanje]

Made some changes:

1. Added test cases for Gitlab and Github to cover the situation where a tag is pushed.
2. Moved the script to testdata to keep concerns contained.
3. Moved the test data to testdata/src to keep it out of the concerns root.
4. Updated the integration tests to look for tests in testdata/src