fix: prevent panic in cucumber JSON formatter on stopOnFailure #717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
fmt_cucumber_test.go) to assert the changesThis PR is a follow up to this other PR
⚡️ What's your motivation?
I use godog for professional integration tests that run in our PR pipeline, and we rely on a report being generated for every run (both success and failure). These test suites can take up to an hour when they pass, so we enable stopOnFailure to fail fast and free up CI resources as soon as a single scenario fails.
However, when stopOnFailure is enabled and a scenario fails, the cucumber JSON formatter panics before writing the report, so we can’t collect the partial report for the scenarios that did run. This change ensures we still get a valid JSON report even when the run stops early.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.