Skip to content

Release workflows #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Release workflows #27

merged 6 commits into from
Sep 13, 2022

Conversation

mattwynne
Copy link
Member

@mattwynne mattwynne commented Aug 12, 2022

🤔 What's changed?

  • Added release workflows copied over from cucumber-expressions (removed the python one as there's no python port of messages right now.)

⚡️ What's your motivation?

Part of cucumber/common#2029

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I might need some help with the remaining languages cc @WannesFransen1994 @ciaranmcnulty @ehuelsmann

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

Sorry, something went wrong.

I removed the python one as there's no python port of messages right
now.

Still needs:

* exlixir
* perl
* php
@mattwynne
Copy link
Member Author

It seems like PHP/Composer just needs a git url/tag so very similar to Go.

We could either make a new action-publish-subrepo that we can use to publish the php (and go) folders to their own subrepos, or we could tell php/go users to use a path within the repo. They will end up cloning the whole polyglot repo but perhaps that's not such a big deal now it's not the whole monorepo.

Thoughts @ciaranmcnulty @vearutop?

@vearutop
Copy link
Member

Yes, I think the size of this repo is ok, we can use it directly without subrepos.

We just need to change module name to github.com/cucumber/messages/go/v19 in https://github.com/cucumber/messages/blob/main/go/go.mod#L1.

@mattwynne
Copy link
Member Author

OK I think we're there.

@vearutop @ciaranmcnulty I decided to build a thing for publishing to a subrepo anyway.

Can someone give this a look-over before we merge and try it out?

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but can’t speak to other langs)

@ciaranmcnulty
Copy link
Contributor

PHP thing looks ok to me, how would it be tested?

Do the target repository's webhooks fire when this is done from a workflow?

@mattwynne
Copy link
Member Author

mattwynne commented Sep 13, 2022

PHP thing looks ok to me, how would it be tested?

See the CONTRIBUTING.md for https://github.com/cucumber/action-publish-subrepo

tl'dr there's some unit tests for the code shell script that work with local git repos, and then a fairly convoluted acceptance testing setup that actually runs the action in the github.com/cucumber/action-publish-subrepo-test-monorepo repo, and proves that ii publishes the right stuff into github.com/cucumber/action-publish-subrepo-test-monorepo-a-subfolder

Do the target repository's webhooks fire when this is done from a workflow?

That target repo will receive a git push --force so I'd assume the push event will fire as normal.

@mattwynne mattwynne merged commit 7984785 into main Sep 13, 2022
@mattwynne mattwynne deleted the release-workflows branch September 13, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants