-
-
Notifications
You must be signed in to change notification settings - Fork 22
Release workflows #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I removed the python one as there's no python port of messages right now. Still needs: * exlixir * perl * php
It seems like PHP/Composer just needs a git url/tag so very similar to Go. We could either make a new Thoughts @ciaranmcnulty @vearutop? |
Yes, I think the size of this repo is ok, we can use it directly without subrepos. We just need to change module name to |
OK I think we're there. @vearutop @ciaranmcnulty I decided to build a thing for publishing to a subrepo anyway. Can someone give this a look-over before we merge and try it out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but can’t speak to other langs)
PHP thing looks ok to me, how would it be tested? Do the target repository's webhooks fire when this is done from a workflow? |
See the CONTRIBUTING.md for https://github.com/cucumber/action-publish-subrepo tl'dr there's some unit tests for the code shell script that work with local git repos, and then a fairly convoluted acceptance testing setup that actually runs the action in the github.com/cucumber/action-publish-subrepo-test-monorepo repo, and proves that ii publishes the right stuff into github.com/cucumber/action-publish-subrepo-test-monorepo-a-subfolder
That target repo will receive a |
🤔 What's changed?
⚡️ What's your motivation?
Part of cucumber/common#2029
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I might need some help with the remaining languages cc @WannesFransen1994 @ciaranmcnulty @ehuelsmann
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.