Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thanks.gen: don't add an extra · at the end #378

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

emanuele6
Copy link
Contributor

#187 version 2 :D

This is achieved by generating thanks.gen as

user1
·
user2
·
user3

Instead of as

user1 ·
user2 ·
user3 ·

  would add an unwanted extra (non-breaking) space, so I just removed it.

@bagder
Copy link
Member

bagder commented Aug 12, 2024

  would add an unwanted extra (non-breaking) space, so I just removed it.

I think this makes the output a little uglier: previously each line would always end with the middot but without the nbsp in there, lots of lines will have the middot wrapped to instead start the line below instead. Which I think looks a little less "tidy".

@emanuele6
Copy link
Contributor Author

Thank you, now I see what difference the   before · makes. I put it back!

curl#187 version 2 :D

Now  · is only added to the end of lines before the last one
instead of to the end of all lines.
@bagder bagder merged commit 35617c0 into curl:master Aug 16, 2024
3 checks passed
@bagder
Copy link
Member

bagder commented Aug 16, 2024

Thanks!

@emanuele6 emanuele6 deleted the foo branch August 16, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants