Skip to content

Run latest stable vscode version in CI tests #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Run latest stable vscode version in CI tests #2911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/test-harness/src/launchVscodeAndRunTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) {
// we don't have to update the branch protection rules every time we bump
// the legacy VSCode version.

// NB: Because of a CI crashing issue the vscode version is pinned.
// https://github.com/cursorless-dev/cursorless/issues/2878

const vscodeVersion = useLegacyVscode ? "1.82.0" : "1.97.2";
const vscodeVersion = useLegacyVscode ? "1.82.0" : "stable";
const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion);
const [cli, ...args] =
resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
Expand Down
Loading