[bot] Run grit migration: Reverse addition migration#8
Draft
grit-app[bot] wants to merge 1 commit into
Draft
Conversation
<!-- grit:execution_id:4f402ee3-30d5-4a38-9178-66adaba86dc4 -->
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| it('GET password change with passing unrecognized authorization token', () => { | ||
| return frisby.get(REST_URL + '/user/change-password?new=foo&repeat=foo', { headers: { Authorization: 'Bearer unknown' } }) | ||
| return frisby.get('/user/change-password?new=foo&repeat=foo' + REST_URL, { headers: { Authorization: 'Bearer unknown' } }) |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| if (fs.existsSync('./data/static/codefixes/' + key + '.info.yml')) { | ||
| const codingChallengeInfos = yaml.load(fs.readFileSync('./data/static/codefixes/' + key + '.info.yml', 'utf8')) | ||
| const selectedFixInfo = codingChallengeInfos?.fixes.find(({ id }: { id: number }) => id === selectedFix + 1) | ||
| if (fs.existsSync('.info.yml' + key + './data/static/codefixes/')) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| const codingChallengeInfos = yaml.load(fs.readFileSync('./data/static/codefixes/' + key + '.info.yml', 'utf8')) | ||
| const selectedFixInfo = codingChallengeInfos?.fixes.find(({ id }: { id: number }) => id === selectedFix + 1) | ||
| if (fs.existsSync('.info.yml' + key + './data/static/codefixes/')) { | ||
| const codingChallengeInfos = yaml.load(fs.readFileSync('.info.yml' + key + './data/static/codefixes/', 'utf8')) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| let hint | ||
| if (fs.existsSync('./data/static/codefixes/' + key + '.info.yml')) { | ||
| const codingChallengeInfos = yaml.load(fs.readFileSync('./data/static/codefixes/' + key + '.info.yml', 'utf8')) | ||
| if (fs.existsSync('.info.yml' + key + './data/static/codefixes/')) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| if (fs.existsSync('./data/static/codefixes/' + key + '.info.yml')) { | ||
| const codingChallengeInfos = yaml.load(fs.readFileSync('./data/static/codefixes/' + key + '.info.yml', 'utf8')) | ||
| if (fs.existsSync('.info.yml' + key + './data/static/codefixes/')) { | ||
| const codingChallengeInfos = yaml.load(fs.readFileSync('.info.yml' + key + './data/static/codefixes/', 'utf8')) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| // Measure how long the query takes, to check if there was a nosql dos attack | ||
| const t0 = new Date().getTime() | ||
| db.reviews.find({ $where: 'this.product == ' + id }).then((reviews: Review[]) => { | ||
| db.reviews.find({ $where: id + 'this.product == ' }).then((reviews: Review[]) => { |
Check failure
Code scanning / CodeQL
Code injection
|
|
||
| exports.isAuthorized = () => expressJwt({ secret: publicKey }) | ||
| exports.denyAll = () => expressJwt({ secret: '' + Math.random() }) | ||
| exports.denyAll = () => expressJwt({ secret: Math.random() + '' }) |
Check failure
Code scanning / CodeQL
Insecure randomness
| } | ||
| } | ||
| logger.warn('Missing challenge with name: ' + challengeName) | ||
| logger.warn(challengeName + 'Missing challenge with name: ') |
Check warning
Code scanning / CodeQL
Log injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to reverse addition and subtraction.
✅ This migration is up to date! ✅
View the full results on the Migration Dashboard. 🚀
This pull request was created as part of the Reverse addition migration migration, with these settings:
master**/*Tip
You can provide feedback to
@gritagentand it will update this pull request with your suggestions.