Repository navigation
fix(ui): preserve page state and back navigation across rotation - #570
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf04fa73a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 51 functions across 10 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check 标题准确概括了本次变更的主要内容：修复旋转时页面状态和返回导航的保持问题。 Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review |
✅ Action performed
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1d181b1b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai review |
✅ Action performed
|
|
@coderabbitai review |
✅ Action performed
|
|
@coderabbitai review |
✅ Action performed
|
带入上游： - fix(ui): preserve page state and back navigation across rotation (cwuom#570) - fix(download): prevent cancelled mobile batches from restoring (cwuom#566) - fix(nowplaying): sync matched favorites and refine song sheets (cwuom#562) - feat(lyrics): add ColorOS 16/17 lockscreen lyrics with Root and Shizuku (cwuom#563) - fix(lyrics): preserve Bluetooth lyrics in display metadata (cwuom#560) - fix(ui): stabilize cover morphs and improve Clean switch contrast (cwuom#561) - fix(netease): isolate rejected songs during playlist sync (cwuom#559) - feat(backup): protect configuration exports and warn on HTTP WebDAV (cwuom#557) - perf(ui): defer expensive UI work and complete Clean theme styling (cwuom#556) - fix(auth): persist accounts when Android Keystore is unavailable (cwuom#554) - fix(lyrics): apply translation mode before publishing songs (cwuom#553) - fix(local): restore scanned audio playback and metadata writes (cwuom#551) 与心动模式改动的重叠文件（NowPlayingScreen、NowPlayingQueueSheet、 MoreOptionsMainContent、PersistedPlayerState、PersistedPlayerStateMapping、 PlayerManager、PlayerManagerPersistenceExtensions、NeteaseClient）均为自动合并， 无冲突；heartbeatMode 持久化字段与恢复调用保持完整。
描述 / Description
手机播放器横屏后切回竖屏时，宿主 Activity 重建会丢失底层页面的内存状态，导致内容重载及返回体验不连续。
现在由现有 Compose 页面响应方向和窗口配置变化，并重新应用方向锁与导航栏策略。语言和一加密度适配 Context 使用增量配置，避免旧方向、窗口尺寸或主题配置覆盖后续系统更新；密度适配同时保留明确选择的应用语言，跟随系统模式不固定语言。动态切换语言后在应用入口恢复设备密度适配，保持引导页预览缩放一致。
完整 Activity 旋转回归使用独立的离线 AVD，保留真实播放器点击、旋转、草稿、详情滚动和系统返回断言。CI 使用单值参数绕过 AGP 对逗号列表的截断，在现有测试 Runner 中恢复原生排除列表；额外核对 XML，要求普通分片没有独立宿主测试泄漏，旋转宿主只执行 Clean、Material 两例且均通过，避免前置条件跳过被当作成功。
类型 / Type
修复或解决的问题 / Issues Fixed or Closed by This PR
修复用户反馈的播放器横竖屏切换后需要额外返回、关闭后原页面内容重载的问题。
清单 / Checklist
其他信息 / Additional Information
验证结果：
d0a31ee7的 CI #1105 首次运行已终态成功：8 项任务通过，Telegram 发布步骤按 PR 条件跳过；Native USB 36/36，无签名 Release 构建成功d0a31ee7的远端 app/common JVM 报告：3566 项通过，1 项依赖本地网易云 Cookie 的烟测按既有条件跳过；本地语言、密度、导航与方向的针对性回归 33/33 通过:app:assembleDebug :app:assembleDebugAndroidTest、:app:lintDebug verifyModuleBoundaries --offline及git diff --check通过CI 跟进时修复同步工作目录测试的就绪文件握手：子进程原先创建文件后再写入，父进程可能读到空串并误报锁检查失败；现在完整写入同目录临时文件后原子发布，保留全部锁和回收断言。本地跨进程回归 16/16；同步模块全量 1027 通过、2 项容量测试和 1 项未配置的 WebDAV Provider 测试按既有配置跳过。
旋转回归先在修复前确认首次横屏会替换 Activity，修复后验证 Activity 身份、搜索草稿、详情滚动位置和原有返回层级保持。另有真实无旋转开关播放器的对照路径及导航 owner 重组回归。
本次不调整视觉布局，未新增截图或录屏；未操作真实设备。