fix: Add optional tool_calls arg to ChatMessage.assistant#143
Merged
restlessronin merged 1 commit intocyberchitta:mainfrom Mar 15, 2026
Merged
Conversation
…nsistency - add :tool_calls to ChatMessage map_fields - Update assistant/1 to assistant/2 to accept optional tool_calls - Update userguide to use ChatMessage.assistant explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
tool_callsarg toChatMessage.assistantWhen using function calling in the userguide.livemd, the assistant message from the API response was added directly to context. The problem is API responses use string keys (e.g. "role", "content") while
ChatMessagecreates maps with atom keys. This meant iterating over context required handling bothMap.get(msg, :role)andMap.get(msg, "role").Also, ChatMessage.assistant only accepted content - there was no way to include tool_calls in an assistant message.
Changes:
:tool_callstoChatMessage.map_fieldsassistant/1toassistant/2to accept optionaltool_callsChatMessage.assistantinstead of inserting raw messageDiscovered while building a coding agent that printed context and had to handle both key types.