License fix#77
Merged
Merged
Conversation
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Collaborator
|
Thank you for your reminder, Adam! I will check them now. |
Contributor
Author
|
Also let me know if we can add any of these vendored models to TorchGeo to help. We can easily move any MIT-licensed code to TorchGeo so you don't have to maintain it. Then things could be 100% Apache-2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rs-embed contains a lot of vendored libraries under both Apache-2.0 and MIT licenses. Thus, the license of the entire library should be "Apache-2.0 AND MIT".
Related Issue
N/A
Testing
CHANGELOG.mdfor user-facing API, model, semantic, or installation changes.Notes
You probably also need to add a copyright header to all vendored files. I don't think I saw any files copied from TorchGeo (technically you don't even need
LICENSE.torchgeo) but this would look like:if there were any files from TorchGeo.