set default log file by job outcome #2025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgrahamdawson
force-pushed
the
1241-log-view-set-default-log-file-by-job-outcome
branch
from
dfe8147 to
8f97803
Compare
MetRonnie
reviewed
Jan 13, 2025
markgrahamdawson
force-pushed
the
1241-log-view-set-default-log-file-by-job-outcome
branch
from
f31427b to
44e4d78
Compare
|
LGTM. Works well. Looking at the "network" tab in the web inspector, it looks like we get two We should be able to disable this check if the file is specified in the initial inputs (the query is only needed if the file is not specified). |
MetRonnie
reviewed
Mar 12, 2025
|
Note, we may need to wait until cylc/cylc-uiserver#657 is merged? |
markgrahamdawson
force-pushed
the
1241-log-view-set-default-log-file-by-job-outcome
branch
from
9706db5 to
6e3f8d1
Compare
fix re-implemented based on review fix broken E2E test fix tests review ammends added change log fix linting issue fixed unit tests review amends review amends 2 fixed issue with query call fix linting fix linting fixed issue with network requests review amends fix unit tests split getDefaultFile into workflow and job functions
markgrahamdawson
force-pushed
the
1241-log-view-set-default-log-file-by-job-outcome
branch
from
4b2d273 to
0f4541b
Compare
MetRonnie
reviewed
Mar 27, 2025
| @@ -14,3 +14,4 @@ window.ResizeObserver ??= ResizeObserverStub | |||
| // Mock element scroll API as not currently included in jsdom: | |||
| // https://github.com/jsdom/jsdom/issues/1422 | |||
| Element.prototype.scrollBy ??= function () { } | |||
| Element.prototype.scrollIntoView ??= function () { } | |||
There was a problem hiding this comment.
Ok, might as well put the whole lot in to avoid potential future pain for devs:
Suggested change
| Element.prototype.scrollIntoView ??= function () { } | |
| Element.prototype.scrollIntoView ??= function () { } | |
| Element.prototype.scroll ??= function () { } | |
| Element.prototype.scrollTo ??= function () { } |
There was a problem hiding this comment.
Although I'm curious as to why this is needed on this branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr now implements setting default log file by job outcome in two ways:
If the user navigates to the log view through the node menu the job state is passed to the view as in this pr...
master...MetRonnie:cylc-ui:menu-log-file
If the user manually types in the path of the job via the input in the log view a new query is made as in this pr...
offline data: enable querying failed jobs cylc-uiserver#657
Closes #1241
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.