Repository navigation
Pass integers to sprintf in the hms constructor - #735
Merged
Merged
Conversation
The "as_hms" constructor formatted hours and minutes with "%02d" from doubles computed with %/%. sprintf() only accepts whole doubles for "%d" after its own check, and on the R-hub valgrind platform the hms test failed with "invalid format '%02d'; use format %f, %e, %g or %a for numeric objects". Converting to integer first makes the call independent of the platform's floating point handling.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 82.52% 82.52%
=======================================
Files 230 230
Lines 8689 8689
=======================================
Hits 7171 7171
Misses 1518 1518 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The valgrind job on #733 (R-hub) failed in
test-s3-hms.R:.cstr_construct.hms.as_hms()passed doubles computed with%/%to"%02d", which relies onsprintf()accepting whole doubles. They are now converted withas.integer()first. Output is unchanged, so the snapshot is unchanged.Not reproduced locally (macOS, no valgrind); an R-hub valgrind run is dispatched on this branch to confirm.
R/s3-ITime.Ralready passes integers, no other%dcall on doubles of this kind.🤖 Generated with Claude Code