Skip to content

Conversation

mabela416
Copy link
Contributor

@mabela416 mabela416 commented May 29, 2025

Add a disabled-dark-mode variant mainly for the -dark variants that only have the disabled styles for the light theme and are missing the ones for the dark theme

image

@mabela416 mabela416 self-assigned this May 29, 2025
Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview May 30, 2025 3:54pm

Copy link

cypress bot commented May 29, 2025

cypress-design    Run #2963

Run Properties:  status check passed Passed #2963  •  git commit 506692f5a6 ℹ️: Merge 9984451adfc22b96a5a9ea5958fb0cfd2962fbbc into 98cbe78fc66fa7b80a96acb3488b...
Project cypress-design
Branch Review mabel/add-button-disabled-dark-mode
Run status status check passed Passed #2963
Run duration 05m 04s
Commit git commit 506692f5a6 ℹ️: Merge 9984451adfc22b96a5a9ea5958fb0cfd2962fbbc into 98cbe78fc66fa7b80a96acb3488b...
Committer mabela416
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 236
View all changes introduced in this branch ↗︎
UI Coverage  7.43%
  Untested elements 308  
  Tested elements 26  
Accessibility  99.43%
  Failed rules  0 critical   2 serious   0 moderate   1 minor
  Failed elements 23  

Copy link

changeset-bot bot commented May 30, 2025

🦋 Changeset detected

Latest commit: 9984451

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypress-design/constants-button Minor
@cypress-design/react-button Minor
@cypress-design/vue-button Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mabela416 mabela416 merged commit 5e64008 into main May 30, 2025
23 of 25 checks passed
@mabela416 mabela416 deleted the mabel/add-button-disabled-dark-mode branch May 30, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants