-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(deps): update @testing-library/cypress to 10.1.0 #32617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update @testing-library/cypress to 10.1.0 #32617
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcC399 I saw this warning yesterday and was meaning to address it. Thanks! There's quite a few of these warnings on the repo actually. Open to PRs for thos.
You're welcome!
|
I made a mistake, and this PR does not remove the peer dependency warning, which now appears as a false warning that includes
AFAIK Yarn v1 Classic does not use workspaces to satisfy peer dependencies, so there is no solution to removing the Yarn error message without changing package manager. Even though the error message is not fixed, I suggest to go ahead with the PR so that Cypress is using a version of |
@MikeMcC399 Thanks. We do have a proposal to switch to pnpm, but that's a bit down the road for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcC399 If you update any dependencies in the system-tests directory - you have to unfortunate cd into those directories and run the install for the appropriate package manager of that product independently to get their lockfiles updated. That's what this error is https://app.circleci.com/pipelines/github/cypress-io/cypress/75415/workflows/d08112d8-3bf9-487f-8058-6b9f93fd8a48/jobs/3186146
Thanks for your hint and I'm sorry I missed updating the separate Also, good to hear that you're considering pnpm! I appreciate that migrating to a different package manager is not simple for a complex monorepo like Cypress uses. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Cypress was configured with
@testing-library/cypress
<10.1.0
.Cypress is updated to use @testing-library/[email protected] which is both the minimum version to support Cypress 15 and the
latest
version.Steps to test
confirm no peer dependency warnings related to@testing-library/cypress
.To run all system tests:
How has the user experience changed?
Contributor issue only.
In Cypress packages, the
@testing-library/cypress
npm package is used only indevDependencies
and is not shipped with the Cypress npm package or Cypress binary.PR Tasks
cypress-documentation
?type definitions
?Note
Updates
@testing-library/cypress
to10.1.0
in app, frontend-shared, launchpad, and system test projects with corresponding lockfile changes.@testing-library/cypress
to10.1.0
inpackages/app
,packages/frontend-shared
,packages/launchpad
.10.1.0
:system-tests/projects/vite-ct-function-api
,system-tests/projects/vite-ct-object-api
.yarn.lock
files.Written by Cursor Bugbot for commit 0175ea2. This will update automatically on new commits. Configure here.