-
Couldn't load subscription status.
- Fork 3.4k
chore: refactor @packages/https-proxy to TypeScript and use vitest instead of mocha
#32718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d580c5 to
51da1fc
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/refactor-https-proxy
|
| Run status |
|
| Run duration | 20m 28s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
17
|
|
|
1102
|
|
|
4
|
|
|
26731
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.27%
|
|
|---|---|
|
|
186
|
|
|
158
|
Accessibility
97.97%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
51da1fc to
11c2b46
Compare
11c2b46 to
ebf6a2c
Compare
@packacges/https-proxy to TypeScript and use vitest instead of mocha@packages/https-proxy to TypeScript and use vitest instead of mocha
646d7d8 to
93f28c6
Compare
93f28c6 to
5943d5a
Compare
@packages/https-proxy to TypeScript and use vitest instead of mocha@packages/https-proxy to TypeScript and use vitest instead of mocha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Converts the
@packages/https-proxypackage to TypeScript and makes it a bundled package that ships with declaration types. Additionally, themochatests have been replaced withvitesttests.For the most part, the conversion is 1:1 with the removal of
bluebirdusage and refactoring to useasync/await. Types have also been added heavily to make editing the package much simpler.The test that changed the most was the
ca.spec.tstest as the tests that were in place before didn't have a lot of value on asserting in/out conditions. Instead, these tests have been rewritten to be more of a black box like test to test the main scenarios of the.createfunction.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Rewrites
@packages/https-proxyin TypeScript with CJS/ESM outputs and Vitest tests, removes Bluebird/Mocha, and updates all call sites and configs accordingly.cjs/,esm/), updatedpackage.json(main/module/types, build scripts), tsconfigs, and Vitest config.lib/index.ts(createProxy,resetProxy,CA).http_server,https_server,certs) ported to TS; README notes test parallelism.packages/server/lib/server-base.ts: use{ createProxy as createHttpsProxy }.packages/driverand system-tests: replacehttpsProxy.httpsServerwith test helpercreateHttpsServer; minor fs API fix.{ CA }from new entry; remove legacy spec helper usage.tooling/v8-snapshot: force-no-rewrite path adjusted topackages/https-proxy/cjs/ca.js.packages/https-proxyas completed.Written by Cursor Bugbot for commit 1a0d558. This will update automatically on new commits. Configure here.