Skip to content

Conversation

@AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 14, 2025

  • Closes N/A

Additional details

Converts the @packages/https-proxy package to TypeScript and makes it a bundled package that ships with declaration types. Additionally, the mocha tests have been replaced with vitest tests.

For the most part, the conversion is 1:1 with the removal of bluebird usage and refactoring to use async/await. Types have also been added heavily to make editing the package much simpler.

The test that changed the most was the ca.spec.ts test as the tests that were in place before didn't have a lot of value on asserting in/out conditions. Instead, these tests have been rewritten to be more of a black box like test to test the main scenarios of the .create function.

Steps to test

How has the user experience changed?

PR Tasks


Note

Rewrites @packages/https-proxy in TypeScript with CJS/ESM outputs and Vitest tests, removes Bluebird/Mocha, and updates all call sites and configs accordingly.

  • @packages/https-proxy:
    • TypeScript rewrite; replace Bluebird with async/await and remove Mocha/Sinon.
    • New build outputs (cjs/, esm/), updated package.json (main/module/types, build scripts), tsconfigs, and Vitest config.
    • Public exports now via lib/index.ts (createProxy, resetProxy, CA).
    • Test helpers (http_server, https_server, certs) ported to TS; README notes test parallelism.
  • Consumers updated:
    • packages/server/lib/server-base.ts: use { createProxy as createHttpsProxy }.
    • packages/driver and system-tests: replace httpsProxy.httpsServer with test helper createHttpsServer; minor fs API fix.
    • Tests and utils updated to import { CA } from new entry; remove legacy spec helper usage.
    • tooling/v8-snapshot: force-no-rewrite path adjusted to packages/https-proxy/cjs/ca.js.
  • CI/Docs:
    • CircleCI: expected mocha result files reduced (8 → 7); cache version bumped.
    • ESM migration guide: mark packages/https-proxy as completed.

Written by Cursor Bugbot for commit 1a0d558. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/refactor-https-proxy branch from 3d580c5 to 51da1fc Compare October 14, 2025 22:17
@cypress
Copy link

cypress bot commented Oct 14, 2025

cypress    Run #66482

Run Properties:  status check passed Passed #66482  •  git commit 1a0d558f5d: Update packages/https-proxy/vitest.config.ts
Project cypress
Branch Review chore/refactor-https-proxy
Run status status check passed Passed #66482
Run duration 20m 28s
Commit git commit 1a0d558f5d: Update packages/https-proxy/vitest.config.ts
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 17
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26731
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.27%
  Untested elements 186  
  Tested elements 158  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

@AtofStryker AtofStryker force-pushed the chore/refactor-https-proxy branch from 51da1fc to 11c2b46 Compare October 15, 2025 01:37
cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/refactor-https-proxy branch from 11c2b46 to ebf6a2c Compare October 15, 2025 01:47
@AtofStryker AtofStryker changed the title chore (DRAFT): refactor @packacges/https-proxy to TypeScript and use vitest instead of mocha chore (DRAFT): refactor @packages/https-proxy to TypeScript and use vitest instead of mocha Oct 15, 2025
cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/refactor-https-proxy branch from 646d7d8 to 93f28c6 Compare October 15, 2025 02:59
@AtofStryker AtofStryker force-pushed the chore/refactor-https-proxy branch from 93f28c6 to 5943d5a Compare October 15, 2025 03:02
@AtofStryker AtofStryker self-assigned this Oct 15, 2025
@AtofStryker AtofStryker changed the title chore (DRAFT): refactor @packages/https-proxy to TypeScript and use vitest instead of mocha chore: refactor @packages/https-proxy to TypeScript and use vitest instead of mocha Oct 15, 2025
@jennifer-shehane jennifer-shehane self-requested a review October 15, 2025 13:39
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@AtofStryker AtofStryker merged commit 4d904e2 into develop Oct 15, 2025
88 of 92 checks passed
@AtofStryker AtofStryker deleted the chore/refactor-https-proxy branch October 15, 2025 18:00
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 18, 2025

Released in 15.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v15.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants