-
Notifications
You must be signed in to change notification settings - Fork 3.4k
dependency: update mime from 3.0.0 to 4.1.0 #32936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Remove deprecated @types/mime - no longer needed with mime v4
|
|
There are some hard errors in this PR. The
According to RFC 9239 from May 2022, |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Changed test Running the following locally now passes: yarn workspace @packages/driver cypress:run --spec cypress/e2e/commands/actions/selectFile.cy.ts |
|
@MikeMcC399 CI won't trigger if the PR is in draft - and moving it out of draft does not trigger CI (probably some way we could automate this), so you'll want to do an empty commit after you move it out of draft to have CI run again. |
Thanks for the reminder about draft status! I knew about that and forgot about it! Since you've done a merge into the PR in the meantime, that has also triggered a CI run. It looks like this is waiting for your approval to continue running the rest of the tests now. |
mimecurrent version 4.x #30144Additional details
In the directories:
mime@^3.0.0to mime@^4.1.0 (currentlatest).The npm module @types/mime is deprecated and shows the message:
Steps to test
In separate terminal window:
In
cypressterminal window:How has the user experience changed?
No change expected to user experience.
PR Tasks
cypress-documentation?type definitions?Note
Upgrades mime to 4.1.0 across packages, removes @types/mime, updates a test to expect text/javascript for .js files, and notes the change in the changelog.
mimeto^4.1.0inpackages/driver,packages/net-stubbing, andpackages/server.@types/mimereferences.packages/driver/cypress/e2e/commands/actions/selectFile.cy.tsto expecttext/javascriptfor.jsfiles.mimeupgrade.Written by Cursor Bugbot for commit 25b5b2d. This will update automatically on new commits. Configure here.