Skip to content

chore: add knip health checks to repo #32994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2025
Merged

chore: add knip health checks to repo #32994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de48f41
chore: add knip health checks to repo
jennifer-shehane Nov 21, 2025
ab9cfd4
move health check to correct package
jennifer-shehane Nov 25, 2025
60b4364
add no exit code
jennifer-shehane Nov 25, 2025
8280c92
Merge branch 'develop' into knip-integration
jennifer-shehane Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .circleci/src/pipeline/@pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1533,6 +1533,15 @@ jobs:
name: Check TS Types
command: NODE_OPTIONS=--max_old_space_size=4096 yarn check-ts --concurrency=1

health-check:
<<: *defaults
steps:
- restore_cached_workspace
- install-required-node
- run:
name: Health Check (Knip)
command: yarn health-check

# a special job that closes the Percy build started by the required jobs
percy-finalize:
<<: *defaults
Expand Down
4 changes: 4 additions & 0 deletions .circleci/src/pipeline/workflows/@main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ linux-x64:
- check-ts:
requires:
- build
- health-check:
requires:
- build
- lint:
name: linux-lint
requires:
Expand Down Expand Up @@ -253,6 +256,7 @@ linux-x64:
# filters: *mainBuildFilters
requires:
- check-ts
- health-check
- npm-angular
- npm-eslint-plugin-dev
- npm-puppeteer-unit-tests
Expand Down
4 changes: 4 additions & 0 deletions .circleci/src/pipeline/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ jobs:
requires:
- internal-pr-build
- external-pr-build
- health-check:
requires:
- internal-pr-build
- external-pr-build
- lint:
name: linux-lint
requires:
Expand Down
4 changes: 1 addition & 3 deletions cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
"build-cli": "tsc -p tsconfig.build.json && tsc -p tsconfig.esm.json && tsx ./scripts/build.ts && tsx ./scripts/post-build.ts",
"clean": "tsx ./scripts/clean.ts",
"dtslint": "dtslint types",
"postinstall": "patch-package && tsx ./scripts/post-install.ts",
"lint": "eslint",
"postinstall": "patch-package && tsx ./scripts/post-install.ts",
"prebuild": "yarn postinstall && tsx ./scripts/start-build.ts",
"size": "t=\"cypress-v0.0.0.tgz\"; yarn pack --filename \"${t}\"; wc -c \"${t}\"; tar tvf \"${t}\"; rm \"${t}\";",
"test": "yarn test-unit",
"test-debug": "npx vitest --inspect-brk --no-file-parallelism --test-timeout=0",
"test-dependencies": "dependency-check . --missing --no-dev --verbose",
Copy link
Member Author

@jennifer-shehane jennifer-shehane Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this wasn't even being called anymore, but this was the intention - to remove this dep.

"test-unit": "vitest run",
"types": "yarn dtslint"
},
Expand Down Expand Up @@ -81,7 +80,6 @@
"@types/sinon": "9.0.9",
"@types/sinon-chai": "3.2.12",
"cross-env": "7.0.3",
"dependency-check": "4.1.0",
"dtslint": "4.2.1",
"eslint": "^9.31.0",
"execa-wrap": "1.4.0",
Expand Down
Loading
Loading