Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add end to end test setup with webdriver-io #158

Merged
merged 27 commits into from
Nov 27, 2024
Merged

Conversation

QZera
Copy link
Collaborator

@QZera QZera commented Oct 13, 2024

Closes #35

@QZera QZera force-pushed the feat/webdriver-io branch 17 times, most recently from 5e11034 to 837c653 Compare October 15, 2024 06:22
maninak
maninak previously approved these changes Oct 15, 2024
@QZera QZera force-pushed the feat/webdriver-io branch 11 times, most recently from 70addcd to 33c58b1 Compare October 17, 2024 06:01
QZera added 16 commits November 27, 2024 08:41
- complete todos
- remove unnecessary comments
- format file

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
- specify vscode version for e2e tests based on the one in package.json
- add caching directory for downloaded vscode versions (include it in .gitignore)

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
- add override for wdio-vscode-service, webdriverio dependency
- update wdio dependencies to their latest versions

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
- Sets the package manager to pnpm v9 in package.json
- Updates the ci workflows to use pnpm v9

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
- Throws an error if e2e tests are run outside of CI
- Cleans up comments and redundant properties in wdio.conf.ts

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
- Moves contents of `test/*` to `test/e2e/*`
- Renames `test/tsconfig.json` to `test/e2e/tsconfig.wdio.json`
- Removes redundant eslint rules, and fixes eslint errors for `*.e2e.ts` files
  - Updates `tsconfig.eslint.json` to extend `tsconfig.wdio.json`
- Renames e2e test files to end with `.spec.ts` instead of `.e2e.ts`

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera QZera force-pushed the feat/webdriver-io branch from db48d0e to bbd0e7e Compare November 27, 2024 06:43
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera QZera force-pushed the feat/webdriver-io branch 2 times, most recently from f4a1e1e to e8b203b Compare November 27, 2024 06:49
@QZera QZera force-pushed the feat/webdriver-io branch from 83f6cfb to 7f2d61c Compare November 27, 2024 06:58
@QZera
Copy link
Collaborator Author

QZera commented Nov 27, 2024

Regarding adding the "final new line" rule on workspace settings. I opted against doing it, since I saw that we don't want it for markdown files in .editorconfig.

Copy link
Collaborator Author

@QZera QZera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got everything, please have a look!

@QZera QZera requested a review from maninak November 27, 2024 07:03
Copy link
Collaborator

@maninak maninak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you so much!

@maninak maninak merged commit 2babfc0 into main Nov 27, 2024
10 checks passed
@maninak maninak deleted the feat/webdriver-io branch November 27, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-to-end testing pipeline
3 participants