Skip to content

unicode escapes #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

unicode escapes #146

wants to merge 1 commit into from

Conversation

@mbostock
Copy link
Member

@mbostock mbostock commented Nov 18, 2025 •
edited
Loading

Ref. d3/d3#4043

@Fil
Copy link
Member

Fil commented Nov 18, 2025

Interestingly when I test this, the minification reinstates the unescaped higher-plane utf-8 characters:

grep -o "[^ -~]" dist/d3-format.min.js
µ
−

@mbostock
Copy link
Member Author

mbostock commented Nov 19, 2025

Oh, that’s fascinating. So we do have to set ascii_only: true whenever we use Terser? I guess it seems surprising that Terser would choose the “wrong” default… shouldn’t we just let Terser do whatever it thinks is best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbostock @Fil