Bug/timeline icon

[ffigueroal]

We found that the play/pause button icons were not working properly on Android devices. We tried to modify them, and we fixed it for Android, but stopped working on iPhone (replaced by emoji).

When trying to override it, we found that the _timerPlay boolean was not externally accessible, so we modified the playButtonConfig to bind the text function.

Seba will try to fix the problem for the different OS, but for now he needs this change to override it in DataSaudi.

[davelandry]

Ahh, I see what you're doing here. We need to give access all of the config methods access to this if they are named functions.

Unfortunately, this new logic here will fail if playButtonConfig.text is set to a String (we can only bind with Functions).

That's why we have configPrep! It's a function exported by d3plus-common that, among other things, will bind this to all Function config methods. Check it out:

import {configPrep} from "d3plus-common";

.config(configPrep.bind(this)(this._playButtonConfig))

Take that for a test run, and let me know if that doesn't work.