Skip to content

Conversation

@cboos
Copy link
Collaborator

@cboos cboos commented Dec 27, 2025

HTML polish: tool titles, AskUserQuestion, fold bar, thinking borders

Summary

HTML polish round focusing on visual consistency and tool distinguishability:

  • Glob tool titles now include path - Parallel Glob calls (same timestamp) are now distinguishable by showing "pattern in path" instead of just "pattern"
  • AskUserQuestion rendering improvements - Added Q:/A: labels with proper styling, purple border for questions, green border for answered questions
  • Fold bar polish - Icons and labels now use consistent --fold-color (#888), reduced border thickness (2px→1px), right-aligned content
  • Thinking messages - Unpaired thinking messages now use full purple border (was using dimmed)
  • Todo priority borders - Medium priority items now have transparent border (was solid)

Test plan

  • Snapshot tests updated and passing
  • Visual verification of Glob tool titles in rendered HTML
  • AskUserQuestion input/result rendering tests passing

Summary by CodeRabbit

  • New Features

    • Improved message titles: added clearer titles for question prompts and glob/pattern inputs; file excerpts now show optional line ranges.
  • Style

    • Updated color tokens (answer background, fold color) and refined fold control spacing, alignment, and border widths.
    • Replaced emoji QA icons with textual "Q:" / "A:" labels and added bold QA label styling.
    • Adjusted various priority/answer accent color usages for visual consistency.
  • Tests

    • Updated snapshots and assertions to match new labels and styles.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 27, 2025

📝 Walkthrough

Walkthrough

Adds title renderers for GlobInput and AskUserQuestionInput to the HTML renderer, enhances ReadInput title metadata, replaces emoji Q/A icons with textual "Q:"/"A:" labels in HTML output, and adjusts CSS tokens and fold/QA styling; tests and snapshots updated to match UI changes.

Changes

Cohort / File(s) Summary
HTML renderer
claude_code_log/html/renderer.py
Added title_GlobInput() and title_AskUserQuestionInput() methods; enhanced title_ReadInput() to include optional line-range info in titles.
Tool formatters / Q&A rendering
claude_code_log/html/tool_formatters.py
Replaced emoji prefixes (❓, ✅) with textual <span> labels "Q:" and "A:" across question rendering and result/output formatters.
Global styles
claude_code_log/html/templates/components/global_styles.css
Changed --answer-bg from #f0fff4 to #fffbf0; added --fold-color: #888``.
Message / fold styles
claude_code_log/html/templates/components/message_styles.css
Adjusted fold-bar alignment to flex-end, updated padding and border widths, set .fold-icon / .fold-label to use --fold-color, removed some thinking-style overrides.
Todo / QA styles
claude_code_log/html/templates/components/todo_styles.css
Replaced several priority/accent color tokens with neutral/alternate tokens, removed left padding from .answer-text, added .qa-label (bold) and adjusted question/answer border colors.
Tests & snapshots
test/test_askuserquestion_rendering.py, test/__snapshots__/test_snapshot_html.ambr
Updated assertions from emojis to "Q:"/"A:" labels; refreshed CSS/UI snapshots to reflect color and layout changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Code review for #63 #64 — touches the same HtmlRenderer file; likely related to the new title methods and renderer imports.

Poem

🐰 A rabbit hopped in with labels to share,
"Q:" and "A:" now sit tidy and fair,
Fold bars in gray, tokens set just so,
Titles that peek where file lines go,
A tiny cheer for the renderer's glow!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: HTML formatting improvements including tool titles, AskUserQuestion rendering, fold bar styling, and thinking borders.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev/another-html-polish-round

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6529520 and b35cffc.

📒 Files selected for processing (1)
  • claude_code_log/html/renderer.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • claude_code_log/html/renderer.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: test (windows-latest, 3.12)
  • GitHub Check: test (windows-latest, 3.10)
  • GitHub Check: test (ubuntu-latest, 3.12)
  • GitHub Check: test (ubuntu-latest, 3.10)
  • GitHub Check: test (ubuntu-latest, 3.11)
  • GitHub Check: test (windows-latest, 3.14)
  • GitHub Check: test (ubuntu-latest, 3.13)
  • GitHub Check: test (ubuntu-latest, 3.14)
  • GitHub Check: test (windows-latest, 3.13)
  • GitHub Check: test (windows-latest, 3.11)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cboos cboos changed the base branch from dev/rename-content-to-message to main December 28, 2025 19:24
cboos and others added 7 commits December 28, 2025 20:29
- Add title_GlobInput showing pattern (e.g., "Glob (*.md)")
- Enhance title_ReadInput to show line range when limit is provided
  - "line N" for single line reads
  - "lines X-Y" for range reads

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add title_AskUserQuestionInput with "❓ Asking questions..." title
- Replace emoji icons (❓/✅) with Q:/A: labels in question/answer blocks
- Swap border colors: assistant color for questions, user color for answers
- Simplify backgrounds: --answer-bg now matches --question-bg
- Add .qa-label CSS class for future styling flexibility

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Reduces visual clutter when all items have the same (default) priority.
Only high and low priority items now display colored left borders.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Lighten --text-muted from #666 to #888 for less visual weight
- Add muted color to fold icons (matching fold labels)
- Right-align fold bar content with extra right padding
- Reduce fold bar bottom border from 2px to 1px

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Separate fold-specific color (#888) from --text-muted (#666) to
preserve readability of other muted text like detail labels.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
When multiple Glob tools are invoked in parallel (same timestamp),
showing only the pattern made them look like duplicates. Now shows
"pattern in path" when path is specified.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Previously unpaired thinking messages used --assistant-dimmed border.
Now all thinking messages consistently use --assistant-color.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@cboos cboos force-pushed the dev/another-html-polish-round branch from 8fce103 to 6529520 Compare December 28, 2025 19:29
@cboos
Copy link
Collaborator Author

cboos commented Dec 28, 2025

⚠️ Warning Docstring coverage is 57.14% which is insufficient.

These format_* and title_* methods are intentionally without docstrings.

@cboos cboos self-assigned this Dec 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #72

coderabbitai bot added a commit that referenced this pull request Dec 28, 2025
Docstrings generation was requested by @cboos.

* #70 (comment)

The following files were modified:

* `claude_code_log/html/renderer.py`
* `claude_code_log/html/tool_formatters.py`
Adds concise docstrings showing typical output format to satisfy
docstring coverage requirements (38 methods documented).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@cboos cboos merged commit 72bc98e into main Dec 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants