Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for file encoding detection #294

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

iMMIQ
Copy link
Contributor

@iMMIQ iMMIQ commented Mar 14, 2025

  • Add chardetng and encoding_rs dependencies in Cargo.toml to detect and decode non-UTF-8 files.
  • Update file reading logic in main.rs to read bytes, detect encoding, and decode file contents.
  • Introduce lint_gbk_encoded_verilog test case to verify processing of GBK-encoded Verilog files.

- Add chardetng and encoding_rs dependencies in Cargo.toml to detect and decode non-UTF-8 files.
- Update file reading logic in main.rs to read bytes, detect encoding, and decode file contents.
- Introduce lint_gbk_encoded_verilog test case to verify processing of GBK-encoded Verilog files.
@iMMIQ
Copy link
Contributor Author

iMMIQ commented Mar 14, 2025

#287 @DaveMcEwan

@dalance
Copy link
Owner

dalance commented Mar 15, 2025

Thank you for your contribution!
I'll merge this PR, so could you add your name to CONTRIBUTING.md?

@iMMIQ
Copy link
Contributor Author

iMMIQ commented Mar 15, 2025

Added my name to CONTRIBUTING.md as requested. https://github.com/dalance/svlint/pull/294/commits/4ad4420b351910f4f43d14ac364b423fb7b4c83b
Thanks for the review and merge!

@dalance dalance merged commit c0ff978 into dalance:master Mar 15, 2025
4 checks passed
@iMMIQ iMMIQ deleted the dev/non-utf8 branch March 15, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants