Skip to content

Commit

Permalink
curve: Impl Default ConstantTImeEq and ConditionallySelectable
Browse files Browse the repository at this point in the history
…for `SubgroupPoint` (#672)
  • Loading branch information
AaronFeickert authored Jul 30, 2024
1 parent 79ab6c2 commit 83a57e5
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion curve25519-dalek/src/edwards.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,7 @@ impl GroupEncoding for EdwardsPoint {
/// A `SubgroupPoint` represents a point on the Edwards form of Curve25519, that is
/// guaranteed to be in the prime-order subgroup.
#[cfg(feature = "group")]
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
pub struct SubgroupPoint(EdwardsPoint);

#[cfg(feature = "group")]
Expand Down Expand Up @@ -1510,6 +1510,20 @@ impl MulAssign<&Scalar> for SubgroupPoint {
#[cfg(feature = "group")]
define_mul_assign_variants!(LHS = SubgroupPoint, RHS = Scalar);

#[cfg(feature = "group")]
impl ConstantTimeEq for SubgroupPoint {
fn ct_eq(&self, other: &SubgroupPoint) -> Choice {
self.0.ct_eq(&other.0)
}
}

#[cfg(feature = "group")]
impl ConditionallySelectable for SubgroupPoint {
fn conditional_select(a: &SubgroupPoint, b: &SubgroupPoint, choice: Choice) -> SubgroupPoint {
SubgroupPoint(EdwardsPoint::conditional_select(&a.0, &b.0, choice))
}
}

#[cfg(feature = "group")]
impl group::Group for SubgroupPoint {
type Scalar = Scalar;
Expand Down

0 comments on commit 83a57e5

Please sign in to comment.