Skip to content

Make mobile coach panels full height#1171

Merged
daler91 merged 1 commit into
mainfrom
codex/full-height-mobile-coach-panels
May 14, 2026
Merged

Make mobile coach panels full height#1171
daler91 merged 1 commit into
mainfrom
codex/full-height-mobile-coach-panels

Conversation

@daler91
Copy link
Copy Markdown
Owner

@daler91 daler91 commented May 13, 2026

Summary

  • make the global mobile AI Coach panel occupy the full dynamic viewport instead of a 70vh bottom sheet
  • make the mobile workout-scoped coach view take over the full workout sheet canvas, without duplicate sheet chrome or an inset card
  • tighten coach/chat header and composer flex sizing so long titles, badges, and inputs do not force horizontal overflow on mobile

Validation

  • pnpm exec vitest run client/src/components/workout-detail/tests/LogSheet.parse-failure.test.tsx client/src/components/workout-detail/tests/ReviewSurface.test.tsx client/src/components/workout-detail/tests/EmbeddedWorkoutCoachChat.test.tsx client/src/components/workout-detail/tests/PreviewSheet.test.tsx client/src/pages/tests/Timeline.surfaceSync.test.tsx --reporter=dot
  • pnpm exec tsc --noEmit --pretty false
  • pnpm exec eslint client/src/components/ChatInput.tsx client/src/components/CoachPanel.tsx client/src/components/coach/CoachPanelFooter.tsx client/src/components/coach/CoachPanelHeader.tsx client/src/components/ui/responsive-sheet.tsx client/src/components/workout-detail/EmbeddedWorkoutCoachChat.tsx client/src/components/workout-detail/LogSheet.tsx client/src/components/workout-detail/ReadOnlyWorkoutDetailSheet.tsx client/src/components/workout-detail/ReviewSurface.tsx client/src/components/workout-detail/WorkoutCoachPanel.tsx client/src/pages/Timeline.tsx client/src/components/workout-detail/tests/EmbeddedWorkoutCoachChat.test.tsx client/src/components/workout-detail/tests/PreviewSheet.test.tsx
  • git diff --check
  • pnpm exec vitest run client/src/components/timeline/tests/TimelineFilters.test.tsx --reporter=dot

Note: pnpm test -- --reporter=dot reached the touched coach suites successfully, then timed out in two unrelated TimelineFilters cases under full-suite load. The same TimelineFilters file passed immediately when rerun in isolation.

@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sonarqubecloud
Copy link
Copy Markdown

@cypress
Copy link
Copy Markdown

cypress Bot commented May 13, 2026

Default Project    Run #3209

Run Properties:  status check passed Passed #3209  •  git commit 66cc12986c: Merge pull request #1171 from daler91/codex/full-height-mobile-coach-panels
Project Default Project
Branch Review main
Run status status check passed Passed #3209
Run duration 02m 23s
Commit git commit 66cc12986c: Merge pull request #1171 from daler91/codex/full-height-mobile-coach-panels
Committer daler91
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 70
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@daler91 daler91 merged commit 66cc129 into main May 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant