Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#716 add full screen images #776

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kuba-04
Copy link
Contributor

@kuba-04 kuba-04 commented Mar 8, 2025

fixes #716

@kuba-04 kuba-04 mentioned this pull request Mar 8, 2025
@kuba-04 kuba-04 marked this pull request as ready for review March 8, 2025 17:06
@kernelkind
Copy link
Member

Nice! My only suggestion would be to make the "go to top" button more dark when an image is in full screen mode, it's a bit weird

@jb55
Copy link
Contributor

jb55 commented Mar 10, 2025

it doesn't seem like the full size image is displayed? its the same size of the image in the timeline

@kuba-04
Copy link
Contributor Author

kuba-04 commented Mar 10, 2025

you are right, it was using the existing cached image, although confusing because for me some of them were showing up in the same size as original under its url.

I am going to load up a fresh full res image into cache upon click. That is not difficult I think. But there will be some playing around with zooming in/out and navigating the large image. I will get back soon

@jb55
Copy link
Contributor

jb55 commented Mar 10, 2025

perhaps when we are about to save the image to cache we should just resize to a reasonably sized image that would look great in all contexts, instead of having to redownload

@kuba-04
Copy link
Contributor Author

kuba-04 commented Mar 11, 2025

ok got it. I won't be lying, claude 3.7 sonnet although sometimes annoying, this time it authored those zoom and drag maths you will find there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full screen images
3 participants