Fix 001084 demo: pin pynwb==3.0.0, hdmf==4.3.1 - #172
Merged
Merged
Conversation
The previous pins (pynwb==2.8.3 + hdmf==6.0.1) are incompatible: hdmf 6.x declares `external_resources` as an abstract method that pynwb 2.8.3's NWBFile does not implement, so `io.read()` fails with `TypeError: Can't instantiate abstract class NWBFile ...`. pynwb 3.0.0 (NWB Schema 2.8) pairs with a compatible hdmf (>=3.14.5,<5) and reads the file cleanly. Same fix as #170. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
Preview for this PR has been removed (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as #170, applied to
001084/HoweLab/001084_demo.ipynb.The install cell pinned pynwb==2.8.3 + hdmf==6.0.1, an incompatible pair: hdmf 6.x declares
external_resourcesas an abstract method that pynwb 2.8.3'sNWBFiledoes not implement, soio.read()fails with:Pinning pynwb==3.0.0 (NWB Schema 2.8) + hdmf==4.3.1 resolves it — pynwb 3.0.0 declares
hdmf>=3.14.5,<5, so the pair is compatible. Only the two pin lines changed.🤖 Generated with Claude Code