Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix big JSON passed from subprocess being cut short #605

Closed
wants to merge 3 commits into from

Conversation

LarsJK
Copy link

@LarsJK LarsJK commented May 27, 2018

Fixes #603

@LarsJK
Copy link
Author

LarsJK commented May 27, 2018

Looks like I broke async running.. Will have another go at it..

@LarsJK
Copy link
Author

LarsJK commented May 28, 2018

Not sure why Travis fails..

@orta
Copy link
Member

orta commented May 28, 2018

The node 9 runner is the runner which runs Danger like a consumer CI, it looks like the JSON it thinks is the response from the subprocess is {} (logs).

screen shot 2018-05-28 at 8 04 47 am

Could it be that more than one JSON object is being sent over, and getting to the results processor here: https://github.com/danger/danger-js/blob/master/source/runner/Executor.ts#L122-L125

@orta
Copy link
Member

orta commented Oct 10, 2018

I got a fix coming up for this in a week or two, so I'm going to close this for now 👍

@orta orta closed this Oct 10, 2018
@peril-staging
Copy link
Contributor

peril-staging bot commented Oct 10, 2018

Thanks for the PR @LarsJK.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks LarsJK 🎉

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants