Group function closer to the original one #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it more compatible with the original api
Made it more compatible with the original api
Update NumberDatum.php
|
Thanks for the PR @lexx27 . Sorry I haven't gotten around to looking at it yet. I'll try to do so before the next PHP-RQL release. |
| @@ -9,13 +9,13 @@ class NumberDatum extends Datum | |||
| { | |||
| public function encodeServerRequest() | |||
| { | |||
| return (float)$this->getValue(); | |||
There was a problem hiding this comment.
Because all the numbers are saved as float. I couldn't save integers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group function had some problem with the arguments.
ex. the way arguments were passed was not like the js api
Also the "multi" option was ignored
I hope that my code is not total trash