fix: resolve WebUI tooltips not rendering due to overflow clipping #1904
+148
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use position: fixed and getBoundingClientRect() to calculate tooltip position dynamically. This prevents tooltips from being clipped by parent containers with overflow: hidden (such as slide transitions). Closes danielmiessler#1790 Signed-off-by: majiayu000 <[email protected]>
Collaborator
|
Merry Christmas! Will look at this soon. |
- Extract positioning calculations into dedicated `positioning.ts` module - Add reactive tooltip position updates on scroll/resize - Improve accessibility with `aria-describedby` and unique IDs - Add SSR safety with `isBrowser` flag check - Replace inline position calculation with reactive statement - Add window event listeners for position tracking - Update unit tests to use extracted functions - Add test coverage for style formatting function
ksylvan
force-pushed
the
fix/webui-tooltips-rendering-1790
branch
from
655eb67 to
4d0e1e7
Compare
ksylvan
approved these changes
Dec 25, 2025
Collaborator
ksylvan
left a comment
ksylvan
left a comment
There was a problem hiding this comment.
Approved with some refactoring. Thanks, @majiayu000 !!!
Contributor
Author
|
Thanks for the review and refactoring improvements! Merry Christmas! 🎄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this Pull Request (PR) does
Fixes tooltip visibility issue in WebUI Model Controls by using
position: fixedpositioning instead ofposition: absolute.Problem: Tooltips were being clipped by parent containers with
overflow: hidden(caused by Svelte slide transitions).Solution: Calculate tooltip position using
getBoundingClientRect()and apply fixed positioning to escape overflow constraints.Related issues
Closes #1790
Screenshots
The tooltip now correctly renders above the parent container boundaries.