fix(installer): respect PAI_DIR choice during installation #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installer prompted users about using their existing $PAI_DIR but ignored the response, always installing to ~/.claude. This fix: - Adds installDir field to WizardConfig interface - Captures user's PAI_DIR choice in gatherConfig() - Uses config.installDir instead of hardcoded ~/.claude in main() - Updates summary messages to show actual install location Discovered when PAI_DIR was set to ~/PAI but installer wrote to ~/.claude. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Owner
|
Thank you @banjoey for catching this PAI_DIR installer bug! 🙏 PAI v2.1 includes a completely revamped wizard-style installer with proper environment detection. Your bug report helped drive these improvements - the installer now properly respects user choices. The paths have changed ( See the release: https://github.com/danielmiessler/PAI/releases/tag/v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$PAI_DIR~/.claudeProblem
When running
bun run install.ts, if$PAI_DIRis set, the installer asks:Answering "yes" was acknowledged in the output but completely ignored - installation always went to
~/.claude.Root Cause
In
install.ts, thegatherConfig()function displayed the PAI_DIR prompt but never captured or returned the user's choice. Themain()function then used a hardcoded path:Fix
installDir: stringtoWizardConfiginterfacegatherConfig()and included it in the return valuemain()to useconfig.installDirinstead of hardcoded pathTesting
Tested by:
PAI_DIRin shell profilebun run install.ts$PAI_DIRinstead of~/.claude🤖 Generated with Claude Code