Open
Conversation
danieltichiyama
requested changes
Oct 27, 2020
Comment on lines
+16
to
+38
| const clearReservations = () => { | ||
| let waitLength = waitList.length; | ||
| let holdLength = holdList.length; | ||
|
|
||
| if (waitLength === 0 && holdLength === 0) { | ||
| return alert('No reservations to cancel.'); | ||
| } | ||
| if (waitLength !== 0) { | ||
| waitList.forEach((res) => { | ||
| let data = { queueStatus: 'cancelled' } | ||
| props.dispatchUpdateReservation(data, res.id); | ||
| }); | ||
| alert(`Wait list cleared ${waitLength} reservations.`) | ||
| }; | ||
| if (holdLength !== 0) { | ||
| holdList.forEach((res) => { | ||
| let data = { queueStatus: 'cancelled' } | ||
| props.dispatchUpdateReservation(data, res.id); | ||
| }) | ||
| alert(`Hold list cleared ${holdLength} reservations.`) | ||
| } | ||
| return | ||
| }; |
Owner
There was a problem hiding this comment.
Hey, I don't think this is good. This requires the front end to fire off a request to the backend for every single reservation on the front, that could be a lot of calls. I think we need to create a new backend route that will update the reservations based on what's saved in the retailer's reservation array.
Owner
There was a problem hiding this comment.
Lemme know if you wanna discuss and we can talk about what that might look like.
Collaborator
Author
There was a problem hiding this comment.
Ok I'll look into updating multiple documents with one call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WaitList includes a clear button on top
It maps through waitList/holdList and changes their status in db to "cancelled"