Draft
Conversation
…ve not changed the tests yet.
dankelleher
force-pushed
the
feature/user-keys
branch
7 times, most recently
from
2e49590 to
305716c
Compare
dankelleher
force-pushed
the
feature/user-keys
branch
from
305716c to
181a8d2
Compare
rado0x54
reviewed
Aug 29, 2021
program/src/state.rs
Outdated
| @@ -96,7 +96,7 @@ pub struct EncryptedKeyData { | |||
| /// The identifier of the key that this key is encrypted with | |||
| pub kid: Kid, // TODO needed? | |||
Collaborator
There was a problem hiding this comment.
What's the type here and should that be also converted to a fixed-size byte representation?
…t transaction integration test now passes, so at a base level, the client-program serialisation/deserialisation is correct, though there may be a couple of bugs left in places.
…aid user creation when creating channels
…aid user creation when creating channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for the switch to the UserKey model - compiles, but I have not changed the tests yet.