removed need for friend declaration of test class in CmdLineParser / cleanups
#7896
+98
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
If this is acceptable we probably can use this pattern for other classes which currently require |
firewave
commented
Oct 17, 2025
Comment on lines
+94
to
+96
| class CmdLineParserTest : public CmdLineParser | ||
| { | ||
| friend class TestCmdlineParser; |
There was a problem hiding this comment.
This allows us to access the protected members.
danmar
reviewed
Oct 25, 2025
There was a problem hiding this comment.
I see no nice solution.
- Friend is horrible but at least it explicitly pointed out the test class.
- The disadvantage with this solution is that if we would ever like to use CmdLineParser as a base class in production code then the derived classes have access to stuff that should really be private.
I have no strong opinion. But I fear that sooner or later somebody will come and look at the code and in his opinion we should have solved it in another way and then we get another PR..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.