Fix #14307 (Update simplecpp to 1.6.3)

[danmar]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[firewave]

externals/simplecpp/simplecpp.cpp:3247:52: warning: Either the condition '!tmp' is redundant or there is possible null pointer dereference: tok. [nullPointerRedundantCheck]
    const simplecpp::MacroMap::const_iterator it = tok->name ? macros.find(tok->str()) : macros.end();
                                                   ^
externals/simplecpp/simplecpp.cpp:3678:29: note: Assuming that condition '!tmp' is not redundant
                        if (!tmp)
                            ^
externals/simplecpp/simplecpp.cpp:3674:52: note: Calling function 'preprocessToken', 2nd argument 'tmp' value is 0
                        if (!preprocessToken(expr, tmp, macros, files, outputList)) {
                                                   ^
externals/simplecpp/simplecpp.cpp:3246:42: note: Assignment 'tok=tok1', assigned value is 0
    const simplecpp::Token * const tok = tok1;
                                         ^
externals/simplecpp/simplecpp.cpp:3247:52: note: Null pointer dereference
    const simplecpp::MacroMap::const_iterator it = tok->name ? macros.find(tok->str()) : macros.end();
                                                   ^
externals/simplecpp/simplecpp.cpp:3247:76: warning: Either the condition '!tmp' is redundant or there is possible null pointer dereference: tok. [nullPointerRedundantCheck]
    const simplecpp::MacroMap::const_iterator it = tok->name ? macros.find(tok->str()) : macros.end();
                                                                           ^
externals/simplecpp/simplecpp.cpp:3678:29: note: Assuming that condition '!tmp' is not redundant
                        if (!tmp)
                            ^
externals/simplecpp/simplecpp.cpp:3674:52: note: Calling function 'preprocessToken', 2nd argument 'tmp' value is 0
                        if (!preprocessToken(expr, tmp, macros, files, outputList)) {
                                                   ^
externals/simplecpp/simplecpp.cpp:3246:42: note: Assignment 'tok=tok1', assigned value is 0
    const simplecpp::Token * const tok = tok1;
                                         ^
externals/simplecpp/simplecpp.cpp:3247:76: note: Null pointer dereference
    const simplecpp::MacroMap::const_iterator it = tok->name ? macros.find(tok->str()) : macros.end();
                                                                           ^

This appears to be a false positive. I filed https://trac.cppcheck.net/ticket/14308 about it.

[firewave]

This appears to be a false positive. I filed https://trac.cppcheck.net/ticket/14308 about it.

So unless you get a quick fix for this we can suppress it in the selfcheck (with the actual line as the source is fixed to avoid others to be missed in the future).

[firewave]

#8014 is attempting to fix the false positives.

[chrchr-github]

#8014 is attempting to fix the false positives.

Looks like that will take a while, so we should probably just suppress the FP for the moment.

[firewave]

Please add the following to .selfcheck_suppressions so we can merge this.

# false positive - see #14308
nullPointerRedundantCheck:externals/simplecpp/simplecpp.cpp:3247