WIP: Fix #14319: originalName missing from the dumpfile #8022
+36
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Dec 10, 2025
swasti16
force-pushed
the
swasti/14319_orignalName
branch
from
bb47e06 to
bc5ae72
Compare
|
danmar
reviewed
Dec 11, 2025
| continue; | ||
| const Token* t = tok->next(); | ||
| std::string existing_data_type; | ||
| while (t && t->str() != ts.name()) { |
Owner
There was a problem hiding this comment.
I don't understand this. why are the type tokens interesting. we are interesting in the typedef name aren't we?
| ASSERT_EQUALS_MSG(false, true, "Validation of Tokenizer failed"); | ||
| } | ||
| const Token* token = Token::findsimplematch(tokenizer.list.front(), "short"); | ||
| ASSERT_EQUALS("uint16", token->originalName()); |
Owner
There was a problem hiding this comment.
As far as I remember we want that the original name for the "A" token to be A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.