Move agent chat Show settings from per-pane to per-machine#293
Merged
mattleaverton merged 23 commits intomainfrom Apr 10, 2026
Merged
Move agent chat Show settings from per-pane to per-machine#293mattleaverton merged 23 commits intomainfrom
mattleaverton merged 23 commits intomainfrom
Conversation
added 23 commits
March 31, 2026 14:38
…ated browser-use test
Priority 3: Integration test for rendering coalesced tool messages Priority 4: Edge case tests (empty content, thinking block, session not found) Priority 5: Invariant tests (message order, model preserved, status updated)
R1 (critical): Add main(argv) function and if __name__ block to tool_coalesce.py - Script can now be run standalone with --help and other CLI args - Follows same pattern as smoke_freshell.py R2 (major): Extend test 4.4 to verify coalescing with malformed lines - Add new test 'coalesces tool messages even when malformed lines are interspersed' - Verifies that tool-only assistant messages are still coalesced correctly when malformed JSON lines appear between them
Revert src/components/TerminalView.tsx to match main branch. The handleImagePaste changes (17 lines) were from an unrelated PR that was merged into this branch accidentally.
…ser state Show thinking, Show tools, and Show timecodes were stored per-pane in AgentChatPaneContent. They now live in LocalSettings (browser-local localStorage), shared across all agent chat panes and persisted across page loads. All three default to off (false).
… settings E2e tests now use preloadedState with showTools: true where expanded tools are expected. CollapsedTurn defaults updated to false. Comments updated to reflect new per-machine defaults.
Migrate showThinking/showTools/showTimecodes from persisted agent-chat pane content into browser-local preferences on module load, so existing users keep their settings after the per-pane → per-machine move.
- SettingsView.agent-chat.test.tsx: 9 tests for Workspace toggles (defaults, preloaded state, toggle on/off, local-only persistence) - browserPreferencesPersistence.test.ts: 4 round-trip tests for agentChat.showThinking/showTools/showTimecodes localStorage persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showThinking,showTools, andshowTimecodessettings from per-pane storage (AgentChatPaneContent) to per-machine browser-local storage (LocalSettings.agentChat), with all three defaulting to off (false)Commits
feat: move agent chat Show settings from per-pane to per-machine browser state— Core migration: types, persistence, UI, component defaults, unit testsfix: update e2e tests and CollapsedTurn defaults for per-machine show settings— First fresheyes review fixesfix: add legacy display settings migration and fix ToolStrip JSDoc— Second fresheyes review: legacy migration, stale comment fixtest: add agent-chat display settings coverage— 9 SettingsView tests + 4 browser-preferences round-trip testsTest plan
SettingsView.agent-chat.test.tsx(9 tests),browserPreferencesPersistence.test.ts(+4 tests),panesPersistence.test.ts(+4 migration tests)