Skip to content

Conversation

@ZeynelKoca
Copy link

@ZeynelKoca ZeynelKoca commented Oct 6, 2025

Description

Adds a way to globally configure the state TTL for dynamo (inspired by #1059).

The defined default TTL will only be used if the state request does not explicitly specify a TTL itself.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@JoostPV
Copy link

JoostPV commented Oct 16, 2025

Would be nice when the different statestores (Redis and Dynamo) behave in a similar way.

@MyMirelHub
Copy link
Contributor

There will be a slight delay in reviewing the DynamoDB-related PRs. We need to address the missing/disabled tests first, which are being tracked in issue #4047. Thanks for your patience!

@ZeynelKoca
Copy link
Author

@sicoyle Ready for another review round

Copy link
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment and then this LGTM - thank you!

@ZeynelKoca
Copy link
Author

one last comment and then this LGTM - thank you!

Fixed. Also updated the docs PR with the same description

sicoyle
sicoyle previously approved these changes Oct 30, 2025
@sicoyle
Copy link
Contributor

sicoyle commented Oct 30, 2025

@ZeynelKoca pls see the build failures and ping when you're ready and I can retrigger 🙏

@ZeynelKoca
Copy link
Author

@sicoyle Fixed a stupid rebase mistake. Try again?

@ZeynelKoca
Copy link
Author

@sicoyle Can the pipeline run get an approval?

sicoyle
sicoyle previously approved these changes Nov 18, 2025
@ZeynelKoca
Copy link
Author

@sicoyle Fixed the formatting 🙏

@ZeynelKoca
Copy link
Author

@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo

@ZeynelKoca ZeynelKoca requested a review from sicoyle November 20, 2025 09:48
@sicoyle
Copy link
Contributor

sicoyle commented Nov 20, 2025

@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo

rerunning, lets see. I know github has been having quite a few issues recently

@ZeynelKoca
Copy link
Author

@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo

rerunning, lets see. I know github has been having quite a few issues recently

Fixed another formatting issue 🙏

Signed-off-by: Zeynel Koca <[email protected]>
ZeynelKoca and others added 3 commits November 21, 2025 09:49
Signed-off-by: Zeynel Koca <[email protected]>
Signed-off-by: Zeynel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants