-
Notifications
You must be signed in to change notification settings - Fork 773
Compensating Workflows Pattern #4665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.16
Are you sure you want to change the base?
Conversation
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
@marcduiker - Let's think over a diagram we could add into the docs and presentation deck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a diagram for this, but this will be part of another PR since I want to update all the workflow related diagrams #4679 .
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-patterns.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-patterns.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcduiker - Can you provide a diagram illustrating compensation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use this to make the compensation examples consistent across all the programming language examples. Here is my suggestions for Task Chaining section
- Line 142 - in JS example add comment "# Apply custom compensation logic here
- In both the Java and Go examples add error handlers in the Task Chaining examples to show where to perform compensation with comment "// Apply custom compensation logic here"
- In all the code examples in this section let's add error handling with a comment to say "// Apply custom compensation logic here", for example in the parallel task execution etc. This way it forces users down the correct path.
Signed-off-by: Marc Duiker <[email protected]>
…rkflow/workflow-patterns.md Signed-off-by: Marc Duiker <[email protected]>
I've added the image in this PR. Let's merge that first so we can add it to the doc here. |
I've made the updates, no work from Cassie required.
…ink to the diagram Signed-off-by: Marc Duiker <[email protected]>
Adding docs for a new workflow pattern: compensating workflows
I added a java example here. This is just a first pass implementation that could be improved upon, but wanted to document the new pattern
@hhunter-ms can you add a diagram to my PR and tweak it as you see fit?