Skip to content

Conversation

nelson-parente
Copy link
Contributor

@nelson-parente nelson-parente commented Jul 25, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This pull request adds a pathFilter option to the OAuth2 and OAuth2 Client Credentials middleware docs. It lets users apply middleware based on request path patterns.

Issue reference

dapr/components-contrib#3906

Signed-off-by: nelson.parente <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelson-parente My main feedback here is that it would be good to create a new section on path filtering and provide more guidance on how to use this, even if this just consist of 4 to 5 additional example of the types of filtering that you can do with an example scenario. It just seems very lightweight for such a great new feature.

@nelson-parente
Copy link
Contributor Author

@nelson-parente My main feedback here is that it would be good to create a new section on path filtering and provide more guidance on how to use this, even if this just consist of 4 to 5 additional example of the types of filtering that you can do with an example scenario. It just seems very lightweight for such a great new feature.

done!

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested as suggested

msfussell and others added 15 commits August 28, 2025 09:40
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
msfussell and others added 6 commits August 28, 2025 09:50
…iddleware/middleware-oauth2clientcredentials.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msfussell msfussell merged commit bcb939c into dapr:v1.16 Aug 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants