-
Notifications
You must be signed in to change notification settings - Fork 771
doc: oauth middleware pathFilter #4745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nelson.parente <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelson-parente My main feedback here is that it would be good to create a new section on path filtering and provide more guidance on how to use this, even if this just consist of 4 to 5 additional example of the types of filtering that you can do with an example scenario. It just seems very lightweight for such a great new feature.
Signed-off-by: nelson.parente <[email protected]>
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested as suggested
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-oauth2.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-oauth2.md
Outdated
Show resolved
Hide resolved
...en/reference/components-reference/supported-middleware/middleware-oauth2clientcredentials.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-oauth2.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-oauth2.md
Outdated
Show resolved
Hide resolved
...en/reference/components-reference/supported-middleware/middleware-oauth2clientcredentials.md
Outdated
Show resolved
Hide resolved
...en/reference/components-reference/supported-middleware/middleware-oauth2clientcredentials.md
Outdated
Show resolved
Hide resolved
...en/reference/components-reference/supported-middleware/middleware-oauth2clientcredentials.md
Outdated
Show resolved
Hide resolved
...en/reference/components-reference/supported-middleware/middleware-oauth2clientcredentials.md
Outdated
Show resolved
Hide resolved
...en/reference/components-reference/supported-middleware/middleware-oauth2clientcredentials.md
Outdated
Show resolved
Hide resolved
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2clientcredentials.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
…iddleware/middleware-oauth2.md Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This pull request adds a pathFilter option to the OAuth2 and OAuth2 Client Credentials middleware docs. It lets users apply middleware based on request path patterns.
Issue reference
dapr/components-contrib#3906