allow to create clients with different dapr-api-token #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iginal env var DAPR_API_TOKEN if found Signed-off-by: Filinto Duran <[email protected]>
filintod
changed the title
Signed-off-by: Filinto Duran <[email protected]>
Member
|
This seems to be a subset of #856, correct? |
Contributor
Author
|
Yes, trying to split it, but if you already reviewed the other, that covers both and we can close this. This is the first PR, and 856 is the second part only workflow related code, as we cannot do nice stacked PRs on forks |
Contributor
Author
|
will close this as the reviews were made on the 2nd part PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallback to original env var DAPR_API_TOKEN if found
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: