Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: go persian online/offline book #126

Merged
merged 1 commit into from
Dec 21, 2022
Merged

add: go persian online/offline book #126

merged 1 commit into from
Dec 21, 2022

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Dec 5, 2022

No description provided.

@nathany
Copy link
Collaborator

nathany commented Dec 7, 2022

Thanks. Would you mind splitting this out by language? See the discussion in #47

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Dec 7, 2022

Thanks. Would you mind splitting this out by language? See the discussion in #47

Yw, No please.

@nathany
Copy link
Collaborator

nathany commented Dec 7, 2022

Even just indicating the language might be a good option.

Thoughts @dariubs?

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Dec 7, 2022

Even just indicating the language might be a good option.

Thoughts @dariubs?

I think don't split books is good, better use ToC

For example: https://github.com/ekalinin/github-markdown-toc#table-of-contents

.
├── English/
│   ├── Free
│   ├── ...
│   ├── Paid
│   └── ...
├── Germany/
│   ├── Free
│   ├── ...
│   ├── Paid
│   └── ...
├── ...
├── Persian/
│   ├── Free
│   ├── ...
│   ├── Paid
│   └── ...
└── ...

@dariubs
Copy link
Owner

dariubs commented Dec 7, 2022

Even just indicating the language might be a good option.

Thoughts @dariubs?

I agree with adding new languages, but this list would be too long for all languages in one file, I think we should create separate files for each language we add and ask the contributors of that language to add their books and descriptions in their own language. And give a link to each language file in the main file.
In this case, it will be easy for users of that language to find books in their own language in search engines.
what do you think?

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Dec 20, 2022

Even just indicating the language might be a good option.
Thoughts @dariubs?

I agree with adding new languages, but this list would be too long for all languages in one file, I think we should create separate files for each language we add and ask the contributors of that language to add their books and descriptions in their own language. And give a link to each language file in the main file. In this case, it will be easy for users of that language to find books in their own language in search engines. what do you think?

No idea for this PR?

@nathany nathany merged commit af1a20c into dariubs:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants