view.c: Disable culling refresh when not in darkroom.

This is to avoid a jump in the filmstrip while in darkroom.

To reproduce, have a set of non edited image.

   - On lighttable select one and press 'f' (goes in full preview).
   - Type 'd' to do to darkroom.
   - Select another picture using the filmstrip (double-click).
   - Apply and iop change.
   - See the jump of selected image in filmstrip to first image.

Closes #18351.

src/views/lighttable.c

@@ -437,7 +437,16 @@ void expose(dt_view_t *self, cairo_t *cr, int32_t width, int32_t height, int32_t
 void enter(dt_view_t *self)
 {
   dt_library_t *lib = self->data;
-  const dt_lighttable_layout_t layout = dt_view_lighttable_get_layout(darktable.view_manager);
+  const dt_lighttable_layout_t layout =
+    dt_view_lighttable_get_layout(darktable.view_manager);
+
+  // enable culling proxy
+  darktable.view_manager->proxy.lighttable.culling_init_mode =
+    _culling_reinit;
+  darktable.view_manager->proxy.lighttable.culling_preview_refresh =
+    _culling_preview_refresh;
+  darktable.view_manager->proxy.lighttable.culling_preview_reload_overlays =
+    _culling_preview_reload_overlays;
 
   // we want to reacquire the thumbtable if needed
   if(!lib->preview_state)
@@ -540,9 +549,6 @@ void init(dt_view_t *self)
   darktable.view_manager->proxy.lighttable.set_preview_state = _preview_set_state;
   darktable.view_manager->proxy.lighttable.view = self;
   darktable.view_manager->proxy.lighttable.change_offset = _lighttable_change_offset;
-  darktable.view_manager->proxy.lighttable.culling_init_mode = _culling_reinit;
-  darktable.view_manager->proxy.lighttable.culling_preview_refresh = _culling_preview_refresh;
-  darktable.view_manager->proxy.lighttable.culling_preview_reload_overlays = _culling_preview_reload_overlays;
 
   // ensure the memory table is up to date
   dt_collection_memory_update();
@@ -569,6 +575,11 @@ void leave(dt_view_t *self)
 {
   dt_library_t *lib = self->data;
 
+  // disable culling proxy
+  darktable.view_manager->proxy.lighttable.culling_init_mode = NULL;
+  darktable.view_manager->proxy.lighttable.culling_preview_refresh = NULL;
+  darktable.view_manager->proxy.lighttable.culling_preview_reload_overlays = NULL;
+
   // ensure we have no active image remaining
   if(darktable.view_manager->active_images)
   {

src/views/view.c

@@ -1143,19 +1143,22 @@ gint dt_view_lighttable_get_zoom(dt_view_manager_t *vm)
 
 void dt_view_lighttable_culling_init_mode(dt_view_manager_t *vm)
 {
-  if(vm->proxy.lighttable.module)
+  if(vm->proxy.lighttable.module
+    && vm->proxy.lighttable.culling_init_mode)
     vm->proxy.lighttable.culling_init_mode(vm->proxy.lighttable.view);
 }
 
 void dt_view_lighttable_culling_preview_refresh(dt_view_manager_t *vm)
 {
-  if(vm->proxy.lighttable.module)
+  if(vm->proxy.lighttable.module
+     && vm->proxy.lighttable.culling_preview_refresh)
     vm->proxy.lighttable.culling_preview_refresh(vm->proxy.lighttable.view);
 }
 
 void dt_view_lighttable_culling_preview_reload_overlays(dt_view_manager_t *vm)
 {
-  if(vm->proxy.lighttable.module)
+  if(vm->proxy.lighttable.module
+    && vm->proxy.lighttable.culling_preview_reload_overlays)
     vm->proxy.lighttable.culling_preview_reload_overlays(vm->proxy.lighttable.view);
 }