don't set top margin on module header unless it has actually changed

This eliminates an infinite refresh loop in the GUI.
darktable-org · Feb 8, 2025 · f5ec516 · f5ec516
1 parent f26de97
commit f5ec516
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/dtgtk/expander.c b/src/dtgtk/expander.c
@@ -280,9 +280,13 @@ static gboolean _adjust_header_position(GtkWidget *widget, cairo_t *cr, GtkWidge
   GtkAdjustment *adjustment = gtk_scrolled_window_get_vadjustment(GTK_SCROLLED_WINDOW(sw));
   gdouble value = gtk_adjustment_get_value(adjustment);
 
-  gtk_widget_set_margin_top(header,
-    CLAMP(value - allocation.y, 0, allocation.height - gtk_widget_get_allocated_height(header)));
-  dt_gui_widget_reallocate_now(widget);
+  int curr_margin_top = gtk_widget_get_margin_top(header);
+  int new_margin_top = CLAMP(value - allocation.y, 0, allocation.height - gtk_widget_get_allocated_height(header));
+  if(new_margin_top != curr_margin_top)
+  {
+    gtk_widget_set_margin_top(header, new_margin_top);
+    dt_gui_widget_reallocate_now(widget);
+  }
 
   return FALSE;
 }