Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view.c: Disable culling refresh when not in darkroom. #18355

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

TurboGit
Copy link
Member

@TurboGit TurboGit commented Feb 4, 2025

This is to avoid a jump in the filmstrip while in darkroom.

To reproduce, have a set of non edited image.

  • On lighttable select one and press 'f' (goes in full preview).
  • Type 'd' to do to darkroom.
  • Select another picture using the filmstrip (double-click).
  • Apply and iop change.
  • See the jump of selected image in filmstrip to first image.

Closes #18351.

@TurboGit TurboGit force-pushed the po/fix-fimstrip-sel-v2 branch from 7ad032d to a7e8046 Compare February 4, 2025 07:12
@TurboGit
Copy link
Member Author

TurboGit commented Feb 4, 2025

This is an alternative implementation for #18352.

@TurboGit TurboGit added this to the 5.0.1 milestone Feb 4, 2025
@TurboGit TurboGit added bugfix pull request fixing a bug scope: UI user interface and interactions scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending priority: high core features are broken and not usable at all, software crashes labels Feb 4, 2025
This is to avoid a jump in the filmstrip while in darkroom.

To reproduce, have a set of non edited image.

   - On lighttable select one and press 'f' (goes in full preview).
   - Type 'd' to do to darkroom.
   - Select another picture using the filmstrip (double-click).
   - Apply and iop change.
   - See the jump of selected image in filmstrip to first image.

Closes #18351.
@TurboGit TurboGit force-pushed the po/fix-fimstrip-sel-v2 branch from a7e8046 to 117c751 Compare February 4, 2025 16:33
@TurboGit TurboGit merged commit 80e5903 into master Feb 4, 2025
7 checks passed
@TurboGit TurboGit deleted the po/fix-fimstrip-sel-v2 branch February 4, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filmstrip inconsistency when going back and forth between darkroom and lighttable
1 participant