Skip to content

#3182. Update augmenting_declarations_A01/02_*.dart tests #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

sgrekhov
Copy link
Contributor

  • Updated assertions and descriptions
  • Augmenting typedefs removed
  • Augmenting non-abstract variables removed
  • Augmenting bodies of functions/getters/setters removed

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Removed initializing expression from abstract variable declaration.
@eernstg eernstg merged commit bd9f510 into dart-lang:master May 22, 2025
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 23, 2025
2025-05-23 [email protected] dart-lang/co19#3182. Update augmenting_declarations_A04_*.dart (dart-lang/co19#3197)
2025-05-22 [email protected] dart-lang/co19#3182. Add application order tests (dart-lang/co19#3196)
2025-05-22 [email protected] dart-lang/co19#3182. Update augmenting_declarations_A01/02_*.dart tests (dart-lang/co19#3195)
2025-05-22 [email protected] dart-lang/co19#3182. Update type_inheritance_A04/5_t*.dart (dart-lang/co19#3194)
2025-05-22 [email protected] dart-lang/co19#3182. Update type_inheritance_A02/3_t*.dart (dart-lang/co19#3193)
2025-05-22 [email protected] dart-lang/co19#3057. Add "diamond" inheritance case to promotion via assignment tests (dart-lang/co19#3179)
2025-05-20 [email protected] dart-lang/co19#3182. Update type_inheritance_A01_* tests (dart-lang/co19#3191)
2025-05-20 [email protected] dart-lang/co19#3182. Update scoping tests (dart-lang/co19#3190)
2025-05-20 [email protected] dart-lang/co19#3182. Add enums and extensions tests (dart-lang/co19#3189)
2025-05-19 [email protected] dart-lang/co19#3182. Remove `augmented` expression tests (dart-lang/co19#3188)
2025-05-16 [email protected] dart-lang/co19#3057. Add promotion via type test tests. Check top and bottom types and Null (dart-lang/co19#3165)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I0720274d910fb4e1385efeb038080995b35656f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430660
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants