Skip to content

fix(cupertino_http): fix a websocket memory leak - #1991

Merged
brianquinlan merged 4 commits into
dart-lang:masterfrom
brianquinlan:websocket_leak
Oct 5, 2026
Merged

brianquinlan merged 4 commits into
dart-lang:masterfrom
brianquinlan:websocket_leak

Conversation

@brianquinlan

Copy link
Copy Markdown
Collaborator

Releases 2.3KiB per WebSocket connection.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@github-actions github-actions Bot added the package:cupertino_http Issues related to package:cupertino_http label Sep 22, 2026

@liamappelbe liamappelbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on that Apple forum thread since 2020 😖

@brianquinlan
brianquinlan merged commit 585d433 into dart-lang:master Oct 5, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:cupertino_http Issues related to package:cupertino_http

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants