✨ Fix: Remove redundant // ignore: must_be_immutable in generated mocks #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'must_be_immutable' ignore comment was unnecessary and has been removed. This streamlines the code by eliminating an unused conditional block, maintaining cleaner and more focused logic.
This variable was declared but never used, causing unnecessary clutter in the code. Removing it improves code readability and maintains cleaner logic in the builder.
The removed test for adding `ignore: must_be_immutable` comments is no longer necessary. It likely reflects obsolete functionality or has been integrated elsewhere in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #795 by removing the redundant // ignore: must_be_immutable from generated mock files.
Since the directive // ignore_for_file: must_be_immutable is already present at the top of the generated files, the additional per-class // ignore: must_be_immutable is unnecessary and causes a dart(duplicate_ignore) warning.
What this PR does:
Keeps the global ignore directive (ignore_for_file)
Removes the redundant local ignore directives added for immutable classes
Removes the existing test that was checking for the presence of the local directive
This change simplifies the generated code and prevents analyzer warnings related to duplicate ignores.