Skip to content

Conversation

dcharkes
Copy link
Collaborator

#2547 fixed Windows, but on MacOS and Linux that didn't work: https://dart-ci.firebaseapp.com/cl/447300/3.

This fix works, verified locally on MacOS.

(No changelog or version bump, only needed for Dart CI.)

Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
code_assets Breaking 0.19.6 0.19.6 0.20.0
Got "0.19.6" expected >= "0.20.0" (breaking changes)
⚠️
hooks Breaking 0.20.1 0.20.1 0.21.0
Got "0.20.1" expected >= "0.21.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

1 similar comment
Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
code_assets Breaking 0.19.6 0.19.6 0.20.0
Got "0.19.6" expected >= "0.20.0" (breaking changes)
⚠️
hooks Breaking 0.20.1 0.20.1 0.21.0
Got "0.20.1" expected >= "0.21.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

Coverage Status

coverage: 77.136%. remained the same
when pulling 44ebcf6 on fix-take-two
into 7a47d05 on main.

@dcharkes dcharkes merged commit 99456de into main Aug 28, 2025
28 checks passed
@dcharkes dcharkes deleted the fix-take-two branch August 28, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants