Skip to content

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Sep 11, 2025

Use the new analysis plugins.

This significantly slows down command-line experience:

$ dart tool/ci.dart --analyze
+dart analyze --fatal-infos pkgs/code_assets pkgs/data_assets pkgs/hooks pkgs/hooks_runner pkgs/json_syntax_generator pkgs/native_analyzer_plugin pkgs/native_test_helpers pkgs/native_toolchain_c pkgs/pub_formats
Analyzing code_assets, data_assets, hooks, hooks_runner, json_syntax_generator, native_analyzer_plugin, native_test_helpers, native_toolchain_c, pub_formats... 0.8s
$ dart tool/ci.dart --analyze
+dart analyze --fatal-infos pkgs/code_assets pkgs/data_assets pkgs/hooks pkgs/hooks_runner pkgs/json_syntax_generator pkgs/native_analyzer_plugin pkgs/native_test_helpers pkgs/native_toolchain_c pkgs/pub_formats
Analyzing code_assets, data_assets, hooks, hooks_runner, json_syntax_generator, native_analyzer_plugin, native_test_helpers, native_toolchain_c, pub_formats... 20.6s

Also, this causes errors in the packages not in the workspace:

Also, there's been a breaking change between the beta release and the latest dev release. So all dev bots fail. Ditto stable is an older version of the analyzer plugin protocol. So all stable bots fail too.

cc @srawlins

Copy link

PR Health

Changelog Entry
Package Changed Files
package:code_assets pkgs/code_assets/pubspec.yaml
package:data_assets pkgs/data_assets/pubspec.yaml
package:hooks pkgs/hooks/lib/src/avoid_import_outside_src_rule_test.dart
pkgs/hooks/pubspec.yaml
package:hooks_runner pkgs/hooks_runner/pubspec.yaml
package:native_toolchain_c pkgs/native_toolchain_c/pubspec.yaml
package:objective_c pkgs/objective_c/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Sep 11, 2025

Coverage Status

coverage: 83.533% (+0.6%) from 82.913%
when pulling 9bc1fb1 on analyzer-plugin
into 813edba on main.

@srawlins
Copy link
Member

Very cool! Thanks for trying out the new plugins!

errors in the packages not in the workspace:

Good catch; I think this is the highest priority issue seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants