-
Notifications
You must be signed in to change notification settings - Fork 754
Update prefer_interpolation_to_compose_strings.md #7053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Explain advantages of string interpolation in prefer_interpolation_to_compose_strings
Summary of ChangesHello @jmun304, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the clarity and completeness of the documentation for a Dart diagnostic by providing a more detailed explanation of why string interpolation is preferred. The changes aim to educate developers on the practical benefits and potential pitfalls associated with different string composition methods. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for the prefer_interpolation_to_compose_strings diagnostic to explain the benefits of using string interpolation. The changes are helpful and clarify the reasoning behind the lint. I have a couple of minor suggestions to improve the wording and ensure it aligns with the Google Developer Documentation Style Guidelines, focusing on grammar and tone.
src/content/tools/diagnostics/prefer_interpolation_to_compose_strings.md
Outdated
Show resolved
Hide resolved
src/content/tools/diagnostics/prefer_interpolation_to_compose_strings.md
Outdated
Show resolved
Hide resolved
…strings.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…strings.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
antfitch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's have @parlough take one last look.
|
Thanks for working on this. However, the source of truth for this doc is in a different repository, in https://github.com/dart-lang/sdk/blob/e4fd90fc45a379570e965585e7f98b639264b616/pkg/linter/messages.yaml#L10212-L10247. If you're still interested in making this change, could you open a PR against that file? I'll follow up this PR to update this file with a comment that clarifies where it should be updated. Sorry about the misdirection and thanks again! |
Explain advantages of string interpolation in prefer_interpolation_to_compose_strings
Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
Fixes #7001
Contribution guidelines:
dart format.<?code-excerptneed to be updated in their source.dartfile as well.