Skip to content

build: drive binary build script#2031

Closed
shumkov wants to merge 4 commits into
feat/reproducibleBuildsfrom
feat/releaseScript
Closed

build: drive binary build script#2031
shumkov wants to merge 4 commits into
feat/reproducibleBuildsfrom
feat/releaseScript

Conversation

@shumkov
Copy link
Copy Markdown
Collaborator

@shumkov shumkov commented Jul 31, 2024

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner July 31, 2024 16:18
Comment thread Dockerfile.rust-build
Comment on lines +1 to +29
# Use the official Rust image based on Debian Bullseye 1.76-bullseye
FROM rust@sha256:607b5e64b8d51f78ac5a37984e64f6493e9a7f90b605fa068be86ff035f48141

# Install necessary packages
RUN apt-get update && apt-get install -y \
clang \
cmake \
git \
wget \
bash \
unzip \
&& if [[ "$TARGETARCH" == "arm64" ]] ; then apt-get install -y gcc-aarch64-linux-gnu; fi \
&& rm -rf /var/lib/apt/lists/*

# Add Rust target
RUN if [[ "$TARGETARCH" == "arm64" ]] ; then RUST_TARGET=aarch64-unknown-linux-gnu; else RUST_TARGET=x86_64-unknown-linux-gnu; fi; \
rustup target add ${RUST_TARGET}

# Install protoc - protobuf compiler
ARG PROTOC_VERSION="25.2"
RUN if [[ "$TARGETARCH" == "arm64" ]] ; then export PROTOC_ARCH=aarch_64; else export PROTOC_ARCH=x86_64; fi; \
curl -Ls https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-${PROTOC_ARCH}.zip \
-o /tmp/protoc.zip && \
unzip -qd /opt/protoc /tmp/protoc.zip && \
rm /tmp/protoc.zip && \
ln -s /opt/protoc/bin/protoc /usr/bin/

# Set the working directory inside the container
WORKDIR /app
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

@shumkov shumkov Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is replacement

Comment thread .cargo/config.toml
Comment on lines +21 to +24
# TODO: I don't think it's a good idea
overflow-checks = false
lto = true
# TODO: I don't think it's a good idea
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justify?

Copy link
Copy Markdown
Collaborator Author

@shumkov shumkov Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Mar 30, 2026

Review Gate

Commit: a892dd57

  • Debounce: 944930m ago (need 30m)

  • CI checks: no CI checks found

  • CodeRabbit review: no comment yet

  • Off-peak hours: off-peak (02:13 PM PT Monday)

  • Run review now (check to override)

@QuantumExplorer
Copy link
Copy Markdown
Member

If we end up doing this, we will start over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants